jack-moseley commented on a change in pull request #3351:
URL: https://github.com/apache/gobblin/pull/3351#discussion_r683766211
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java
##########
@@ -205,6 +210,13 @@ protected void runWorkUnits(List<WorkUnit> workUnits)
throws Exception {
this.eventSubmitter.submit(countEventBuilder);
LOGGER.info("Emitting WorkUnitsCreated Count: " +
countEventBuilder.getCount());
+ MetricContext
+ metricContext =
Instrumented.getMetricContext(ConfigUtils.configToState(ConfigFactory.empty()),
getClass());
+ String workUnitCountName =
MetricRegistry.name(this.jobContext.getJobState().getProp(ConfigurationKeys.FLOW_GROUP_KEY),
+
this.jobContext.getJobState().getProp(ConfigurationKeys.FLOW_NAME_KEY),
"workunits");
Review comment:
Let's make the name a bit more descriptive than "workunits", maybe just
reuse the `JobEvent.WORK_UNITS_CREATED` name that's used for the events.
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java
##########
@@ -17,6 +17,8 @@
package org.apache.gobblin.cluster;
+import com.codahale.metrics.MetricRegistry;
Review comment:
Are you using
https://gobblin.readthedocs.io/en/latest/developer-guide/CodingStyle/#code-style-template-file?
Seems like the imports are not in the correct order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]