arjun4084346 commented on a change in pull request #3353:
URL: https://github.com/apache/gobblin/pull/3353#discussion_r683817292



##########
File path: 
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
##########
@@ -176,7 +172,7 @@ public void run() {
       // Since we are going to change status to isActive=false, unschedule all 
flows
       List<Spec> specs = new ArrayList<>(this.scheduledFlowSpecs.values());
       for (Spec spec : specs) {
-        onDeleteSpec(spec.getUri(), spec.getVersion());
+        unscheduleSpec(spec.getUri(), spec.getVersion());

Review comment:
       why not have ` 
this.scheduledFlowSpecs.remove(deletedSpecURI.toString());` also?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to