[ 
https://issues.apache.org/jira/browse/GOBBLIN-1508?focusedWorklogId=634869&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634869
 ]

ASF GitHub Bot logged work on GOBBLIN-1508:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Aug/21 23:47
            Start Date: 05/Aug/21 23:47
    Worklog Time Spent: 10m 
      Work Description: codecov-commenter commented on pull request #3354:
URL: https://github.com/apache/gobblin/pull/3354#issuecomment-893898296


   # 
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#3354](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (c75b1f7) into 
[master](https://codecov.io/gh/apache/gobblin/commit/f468bb0743a2d2f3de65abc2bd1a8cc7994c16fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (f468bb0) will **increase** coverage by `6.94%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/gobblin/pull/3354/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3354      +/-   ##
   ============================================
   + Coverage     46.42%   53.37%   +6.94%     
   + Complexity    10115     1129    -8986     
   ============================================
     Files          2052      250    -1802     
     Lines         79626     8214   -71412     
     Branches       8889      920    -7969     
   ============================================
   - Hits          36970     4384   -32586     
   + Misses        39216     3379   -35837     
   + Partials       3440      451    -2989     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...apache/gobblin/runtime/cli/CliEmbeddedGobblin.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvY2xpL0NsaUVtYmVkZGVkR29iYmxpbi5qYXZh)
 | | |
   | 
[...ata/management/dataset/SimpleDatasetRequestor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvU2ltcGxlRGF0YXNldFJlcXVlc3Rvci5qYXZh)
 | | |
   | 
[.../replication/ConfigBasedCopyableDatasetFinder.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcmVwbGljYXRpb24vQ29uZmlnQmFzZWRDb3B5YWJsZURhdGFzZXRGaW5kZXIuamF2YQ==)
 | | |
   | 
[...ompaction/mapreduce/MRCompactorJobPropCreator.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdG9ySm9iUHJvcENyZWF0b3IuamF2YQ==)
 | | |
   | 
[...time/spec\_executorInstance/MockedSpecExecutor.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc3BlY19leGVjdXRvckluc3RhbmNlL01vY2tlZFNwZWNFeGVjdXRvci5qYXZh)
 | | |
   | 
[.../src/main/java/org/apache/gobblin/util/Either.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRWl0aGVyLmphdmE=)
 | | |
   | 
[...g/apache/gobblin/metastore/MysqlDataSourceKey.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsRGF0YVNvdXJjZUtleS5qYXZh)
 | | |
   | 
[.../gobblin/runtime/api/JobSpecSchedulerListener.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYlNwZWNTY2hlZHVsZXJMaXN0ZW5lci5qYXZh)
 | | |
   | 
[...erter/initializer/ConverterInitializerFactory.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9pbml0aWFsaXplci9Db252ZXJ0ZXJJbml0aWFsaXplckZhY3RvcnkuamF2YQ==)
 | | |
   | 
[...ion/hive/dataset/ConvertibleHiveDatasetFinder.java](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9kYXRhc2V0L0NvbnZlcnRpYmxlSGl2ZURhdGFzZXRGaW5kZXIuamF2YQ==)
 | | |
   | ... and [1785 
more](https://codecov.io/gh/apache/gobblin/pull/3354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[f468bb0...c75b1f7](https://codecov.io/gh/apache/gobblin/pull/3354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 634869)
    Time Spent: 20m  (was: 10m)

> add a few metrics in gobblin cluster
> ------------------------------------
>
>                 Key: GOBBLIN-1508
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1508
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> add a few metrics in gobblin cluster and update some from counter to meter, 
> because meter can give both count and rate of an entity



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to