[
https://issues.apache.org/jira/browse/GOBBLIN-1506?focusedWorklogId=635391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635391
]
ASF GitHub Bot logged work on GOBBLIN-1506:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/21 17:16
Start Date: 06/Aug/21 17:16
Worklog Time Spent: 10m
Work Description: autumnust commented on a change in pull request #3352:
URL: https://github.com/apache/gobblin/pull/3352#discussion_r684383665
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java
##########
@@ -288,13 +287,28 @@ public void orchestrate(Spec spec) throws Exception {
flowMetadata.putIfAbsent(TimingEvent.FlowEventConstants.FLOW_EXECUTION_ID_FIELD,
jobExecutionPlanDag.getNodes().get(0).getValue().getJobSpec().getConfigAsProperties().getProperty(ConfigurationKeys.FLOW_EXECUTION_ID_KEY));
- if (flowCompilationTimer != null) {
- flowCompilationTimer.stop(flowMetadata);
+ if (flowCompilationTimer.isPresent()) {
+ flowCompilationTimer.get().stop(flowMetadata);
}
if (this.dagManager.isPresent()) {
- //Send the dag to the DagManager.
- this.dagManager.get().addDag(jobExecutionPlanDag, true, true);
+ try {
+ //Send the dag to the DagManager.
+ this.dagManager.get().addDag(jobExecutionPlanDag, true, true);
+ } catch (Exception ex) {
+ // pronounce failed before stack unwinds, to ensure flow not
marooned in `COMPILED` state; (failure likely attributable to DB cnxn/failover)
Review comment:
what does `cnxn` mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 635391)
Time Spent: 1h (was: 50m)
> Disable CleanableMysqlDatasetStoreDatasetTest unit tests, since failing local
> build.
> ------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1506
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1506
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Kip Kohn
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> NOTE: these tests are already skipped in Continuous Integration.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)