[ 
https://issues.apache.org/jira/browse/GOBBLIN-1502?focusedWorklogId=635396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635396
 ]

ASF GitHub Bot logged work on GOBBLIN-1502:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Aug/21 17:22
            Start Date: 06/Aug/21 17:22
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on pull request #3344:
URL: https://github.com/apache/gobblin/pull/3344#issuecomment-894404144


   > @arjun4084346 Just want to confirm that have you verified when there is 
partition, add_partition will throw AlreadyExistsException but not other 
exception? Same for get_partition and NoSuchObjectException. Asking because I 
barely remember I do see some other TException been throw when there is no 
partition exist. If that's not the case, the PR LGTM
   
   Yes, I verified. Also added a unit test to confirm what exact exception hive 
client returns in case a) partition already exists, b) partition does not exist.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 635396)
    Time Spent: 1h  (was: 50m)

> fix incorrect add and alter hive partition operations
> -----------------------------------------------------
>
>                 Key: GOBBLIN-1502
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1502
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> During hive registration , do not add a partition if it already exists but 
> the getPartition fails
> with any TException other than NoSuchObjectException and do not alter a 
> partition if a partition does not exist but the add_partition fails with any 
> TException other than AlreadyExistsException



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to