Will-Lo commented on a change in pull request #3358:
URL: https://github.com/apache/gobblin/pull/3358#discussion_r685596475



##########
File path: 
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResourceLocalHandler.java
##########
@@ -215,15 +216,18 @@ private static long 
getFlowStartTime(org.apache.gobblin.service.monitoring.FlowS
    * @param completionPercentage of the job
    * @return time left in seconds

Review comment:
       should be time in string format

##########
File path: 
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/TaskStateCollectorService.java
##########
@@ -281,7 +280,8 @@ private void reportJobProgress(TaskState taskState) {
     this.bytesCopiedSoFar += taskByteSize;
     Double newPercentageCopied = this.bytesCopiedSoFar / this.totalSizeToCopy;
 
-    if (newPercentageCopied - this.lastPercentageReported > 
ConfigurationKeys.DEFAULT_PROGRESS_REPORTING_THRESHOLD) {
+    if (newPercentageCopied - this.lastPercentageReported >= 
ConfigurationKeys.DEFAULT_PROGRESS_REPORTING_THRESHOLD ||
+        (newPercentageCopied > 1 - 
ConfigurationKeys.DEFAULT_PROGRESS_REPORTING_THRESHOLD && 
Math.abs(newPercentageCopied - this.lastPercentageReported) > 0.001)) {

Review comment:
       Let's leave a comment here for what this second scenario covers. Even 
though it's when the job is going from 95-100%, would 0.001 be a bit low of a 
threshold? It'll send up to 50 events reporting from 95-100 for each job, which 
seems a quite different from the previous reporting thresholds. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to