aplex commented on a change in pull request #3327: URL: https://github.com/apache/gobblin/pull/3327#discussion_r685660043
########## File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/db/ServiceDatabaseManager.java ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.service.modules.db; + +import java.util.Objects; + +import org.flywaydb.core.Flyway; + +import com.google.common.util.concurrent.AbstractIdleService; + +import javax.inject.Inject; +import javax.inject.Singleton; +import lombok.extern.slf4j.Slf4j; + + +@Singleton +@Slf4j +public class ServiceDatabaseManager extends AbstractIdleService { + + private final ServiceDatabaseProvider databaseProvider; + + @Inject + public ServiceDatabaseManager(ServiceDatabaseProvider databaseProvider) { + this.databaseProvider = Objects.requireNonNull(databaseProvider); + } + + @Override + protected void startUp() + throws Exception { + + Flyway flyway = + Flyway.configure().locations("classpath:org/apache/gobblin/service/db/migration").failOnMissingLocations(true) + .dataSource(databaseProvider.getDatasource()).load(); + + log.info("Ensuring service database is migrated to latest schema"); + // Start the migration + flyway.migrate(); Review comment: It's ok to have other tables in flyway-managed DB as long as they don't collide in names. Flyway will basically execute the sql config scripts one by one, and that's it. Although, a specific Flyway app shouldn't use the same database as other Flyway apps, as Flyway creates it's own state table that has a fixed name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
