abhisheknath2011 commented on a change in pull request #3349:
URL: https://github.com/apache/gobblin/pull/3349#discussion_r686884929



##########
File path: gobblin-utility/src/main/java/org/apache/gobblin/util/AvroUtils.java
##########
@@ -147,9 +146,10 @@ public static Schema setSchemaCreationTime(Schema 
inputSchema, String creationTi
    * Common use cases for this method is in traversing {@link Schema} object 
into nested level and create {@link Schema}
    * object for non-root level.
    */
-  public static void convertFieldToSchemaWithProps(Map<String,JsonNode> 
fieldProps, Schema targetSchemaObj) {
-    for (Map.Entry<String, JsonNode> stringJsonNodeEntry : 
fieldProps.entrySet()) {
-      targetSchemaObj.addProp(stringJsonNodeEntry.getKey(), 
stringJsonNodeEntry.getValue());
+  public static void convertFieldToSchemaWithProps(Map<String,Object> 
fieldProps,

Review comment:
       If we keep two methods one with jsonNode and other with Object, at some 
point we have to clean this existing method. For example, once we upgrade to 
Jackson 2.x by default 1.x classes need to be removed. Need to keep the Jackson 
1.x classes wherever it is absolutely necessary. For example hive-serde and 
helix jar has Jackson 1.x dependency. So it would be good to remove this method 
and it would be helpful the fix the avro changes in a cleaner way and should be 
able detect issues (if there any) during testing. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to