[
https://issues.apache.org/jira/browse/GOBBLIN-1505?focusedWorklogId=637190&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637190
]
ASF GitHub Bot logged work on GOBBLIN-1505:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/21 00:05
Start Date: 12/Aug/21 00:05
Worklog Time Spent: 10m
Work Description: umustafi commented on a change in pull request #3351:
URL: https://github.com/apache/gobblin/pull/3351#discussion_r687273985
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java
##########
@@ -291,6 +296,14 @@ protected void runWorkUnits(List<WorkUnit> workUnits)
throws Exception {
this.eventSubmitter.submit(countEventBuilder);
LOG.info("Emitting WorkUnitsCreated Count: " +
countEventBuilder.getCount());
+ MetricContext
+ metricContext =
Instrumented.getMetricContext(ConfigUtils.configToState(ConfigFactory.empty()),
getClass());
+ String workUnitCountName =
MetricRegistry.name(ServiceMetricNames.GOBBLIN_SERVICE_PREFIX,
+ jobState.getProp(ConfigurationKeys.FLOW_GROUP_KEY),
jobState.getProp(ConfigurationKeys.FLOW_NAME_KEY),
+ JobEvent.WORK_UNITS_CREATED);
+ ContextAwareGauge guage =
metricContext.newContextAwareGauge(workUnitCountName, () -> workUnits.size());
Review comment:
The issue here is that we don't have access to the number of work units
easily from the GaaS code. One option will be to use the metadata in the
CountEvent like you are suggesting and then emit actual metrics from the point
its landing in GaaS (the KafkaAvroJobStatusMonitor) but that seemed like a
hackier way of doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 637190)
Time Spent: 4.5h (was: 4h 20m)
> Add Metric for WorkUnit count per Flow
> --------------------------------------
>
> Key: GOBBLIN-1505
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1505
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> From a user/platform perspective, we want to see how many workunits are being
> created for each flow. The metric of workunit count will be emitted in the
> form <flowgroup>.<flowname>.workunits
--
This message was sent by Atlassian Jira
(v8.3.4#803005)