[ 
https://issues.apache.org/jira/browse/GOBBLIN-1515?focusedWorklogId=637627&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637627
 ]

ASF GitHub Bot logged work on GOBBLIN-1515:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Aug/21 01:38
            Start Date: 13/Aug/21 01:38
    Worklog Time Spent: 10m 
      Work Description: codecov-commenter commented on pull request #3364:
URL: https://github.com/apache/gobblin/pull/3364#issuecomment-898093924


   # 
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#3364](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (748f78b) into 
[master](https://codecov.io/gh/apache/gobblin/commit/48af4c61c4780740b63931901c756e5a184e763b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (48af4c6) will **decrease** coverage by `3.62%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/gobblin/pull/3364/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3364      +/-   ##
   ============================================
   - Coverage     46.54%   42.92%   -3.63%     
   + Complexity    10136     1944    -8192     
   ============================================
     Files          2051      395    -1656     
     Lines         79547    16950   -62597     
     Branches       8880     2089    -6791     
   ============================================
   - Hits          37027     7275   -29752     
   + Misses        39091     8871   -30220     
   + Partials       3429      804    -2625     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...org/apache/gobblin/iceberg/GobblinMCEProducer.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvR29iYmxpbk1DRVByb2R1Y2VyLmphdmE=)
 | `48.71% <0.00%> (-1.29%)` | :arrow_down: |
   | 
[...pache/gobblin/util/orc/AvroOrcSchemaConverter.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvb3JjL0F2cm9PcmNTY2hlbWFDb252ZXJ0ZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
 | `40.00% <0.00%> (-20.00%)` | :arrow_down: |
   | 
[...g/apache/gobblin/util/filters/RegexPathFilter.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsdGVycy9SZWdleFBhdGhGaWx0ZXIuamF2YQ==)
 | `72.72% <0.00%> (-16.17%)` | :arrow_down: |
   | 
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
 | `92.85% <0.00%> (-7.15%)` | :arrow_down: |
   | 
[...ore/util/DatabaseJobHistoryStoreSchemaManager.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL3V0aWwvRGF0YWJhc2VKb2JIaXN0b3J5U3RvcmVTY2hlbWFNYW5hZ2VyLmphdmE=)
 | `29.31% <0.00%> (-2.36%)` | :arrow_down: |
   | 
[...in/java/org/apache/gobblin/cluster/SingleTask.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlVGFzay5qYXZh)
 | `76.62% <0.00%> (-2.05%)` | :arrow_down: |
   | 
[...che/gobblin/metastore/DatabaseJobHistoryStore.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0RhdGFiYXNlSm9iSGlzdG9yeVN0b3JlLmphdmE=)
 | `77.77% <0.00%> (-0.49%)` | :arrow_down: |
   | 
[.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh)
 | `60.13% <0.00%> (-0.40%)` | :arrow_down: |
   | 
[...main/java/org/apache/gobblin/util/ConfigUtils.java](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQ29uZmlnVXRpbHMuamF2YQ==)
 | `58.59% <0.00%> (-0.27%)` | :arrow_down: |
   | ... and [1663 
more](https://codecov.io/gh/apache/gobblin/pull/3364/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[48af4c6...748f78b](https://codecov.io/gh/apache/gobblin/pull/3364?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 637627)
    Time Spent: 0.5h  (was: 20m)

> Fix hive schema not updated issue in streaming and GMIP
> -------------------------------------------------------
>
>                 Key: GOBBLIN-1515
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1515
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There are two issues need to be fixed:
> 1. Fix the issue that Hive schema is using avro schema even for orc table: 
> Now, since we directly use avro schema literal to calculate the column and 
> column types for orc table, it sometimes is not correct, so we need to change 
> avro schema to orc schema and compute column types accordingly
> 2. Change the behavior that we only evolve avro schema literal but not the 
> hive schema when schema evolution happen: In Streaming, when we do hive 
> registration, we compare the current schema with schema registry and when 
> there is schema evolution, we only update avro schema literal and leave hive 
> schema to be lag. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to