umustafi commented on a change in pull request #3351:
URL: https://github.com/apache/gobblin/pull/3351#discussion_r689805932



##########
File path: 
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaAvroJobStatusMonitor.java
##########
@@ -166,6 +171,16 @@ public GobblinTrackingEvent 
deserializeEvent(DecodeableKafkaRecord<byte[],byte[]
       case TimingEvent.JOB_COMPLETION_PERCENTAGE:
         properties.put(TimingEvent.JOB_LAST_PROGRESS_EVENT_TIME, 
properties.getProperty(TimingEvent.METADATA_END_TIME));
         break;
+      case JobEvent.WORK_UNITS_CREATED:
+        Long numWorkUnits = 
Long.parseLong(properties.getProperty(CountEventBuilder.COUNT_KEY));

Review comment:
       When using a CountEvent that is the default name of the key used to 
store the count quantity if you see 
[here](https://jarvis.corp.linkedin.com/codesearch/result/?name=CountEventBuilder.java&path=gobblin-elr%2Fgobblin-metrics-libs%2Fgobblin-metrics-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Fmetrics%2Fevent&reponame=linkedin%2Fgobblin-elr#59).
 
   
   Edit: It doesn't look like I can rename it even with the  reverse create the 
`CountEvent` from a `GobblinTrackingEvent` where I would be able to specify the 
key name by using the `fromEvent` 
[builder](https://jarvis.corp.linkedin.com/codesearch/result/?name=CountEventBuilder.java&path=gobblin-elr%2Fgobblin-metrics-libs%2Fgobblin-metrics-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Fmetrics%2Fevent&reponame=linkedin%2Fgobblin-elr#74).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to