[
https://issues.apache.org/jira/browse/GOBBLIN-1520?focusedWorklogId=640045&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640045
]
ASF GitHub Bot logged work on GOBBLIN-1520:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/21 22:40
Start Date: 19/Aug/21 22:40
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3370:
URL: https://github.com/apache/gobblin/pull/3370#discussion_r692532012
##########
File path:
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/api/FsSpecProducerTest.java
##########
@@ -106,4 +131,19 @@ public void testDeleteSpec() throws URISyntaxException,
ExecutionException, Inte
Assert.assertEquals(jobSpecs.get(0).getLeft(), SpecExecutor.Verb.DELETE);
Assert.assertEquals(jobSpecs.get(0).getRight().getUri().toString(),
"testDeleteJob");
}
+
+ class TestingFsSpecProducer extends FsSpecProducer {
Review comment:
Can we simply write a dummy file (e.g. using File API) into the spec
path without having to extend FsSpecProducer class? We can avoid having to make
the annotateSpecFilename method package-private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 640045)
Time Spent: 50m (was: 40m)
> Standardize FsSpec file name
> ----------------------------
>
> Key: GOBBLIN-1520
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1520
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
