[
https://issues.apache.org/jira/browse/GOBBLIN-1505?focusedWorklogId=640049&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640049
]
ASF GitHub Bot logged work on GOBBLIN-1505:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/21 22:49
Start Date: 19/Aug/21 22:49
Worklog Time Spent: 10m
Work Description: aplex commented on a change in pull request #3351:
URL: https://github.com/apache/gobblin/pull/3351#discussion_r692535602
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaAvroJobStatusMonitor.java
##########
@@ -166,6 +171,15 @@ public GobblinTrackingEvent
deserializeEvent(DecodeableKafkaRecord<byte[],byte[]
case TimingEvent.JOB_COMPLETION_PERCENTAGE:
properties.put(TimingEvent.JOB_LAST_PROGRESS_EVENT_TIME,
properties.getProperty(TimingEvent.METADATA_END_TIME));
break;
+ case JobEvent.WORK_UNITS_CREATED:
+ Long numWorkUnits =
Long.parseLong(properties.getProperty(CountEventBuilder.COUNT_KEY));
+ String workUnitCountName =
MetricRegistry.name(ServiceMetricNames.GOBBLIN_SERVICE_PREFIX,
+
properties.getProperty(TimingEvent.FlowEventConstants.FLOW_GROUP_FIELD),
+
properties.getProperty(TimingEvent.FlowEventConstants.FLOW_NAME_FIELD),
+ JobEvent.WORK_UNITS_CREATED);
+ ContextAwareGauge gauge =
this.getMetricContext().newContextAwareGauge(workUnitCountName, () ->
numWorkUnits);
Review comment:
We can get "WORK_UNITS_CREATED" event a million times per day, and
multiple times for same flow, if it runs repeatedly. I see that we are creating
a newContextAwareGauge for each event. I wonder if this can result in a memory
leak, when we keep adding gauges on each flow execution. Can you double-check
how this newContextAwareGauge is supposed to be used (in docs, and in other
places in code)? Should we get the existing one, if it's already present?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 640049)
Time Spent: 5.5h (was: 5h 20m)
> Add Metric for JobSize (in bytes/records) per Flow
> --------------------------------------------------
>
> Key: GOBBLIN-1505
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1505
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> From a user/platform perspective, we want to see how many workunits are being
> created for each flow. The metric of workunit count will be emitted in the
> form <flowgroup>.<flowname>.jobSize
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
