[
https://issues.apache.org/jira/browse/GOBBLIN-1525?focusedWorklogId=641996&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641996
]
ASF GitHub Bot logged work on GOBBLIN-1525:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/21 21:38
Start Date: 25/Aug/21 21:38
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on pull request #3376:
URL: https://github.com/apache/gobblin/pull/3376#issuecomment-905894098
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3376?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3376](https://codecov.io/gh/apache/gobblin/pull/3376?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(655b595) into
[master](https://codecov.io/gh/apache/gobblin/commit/a010c7bb45086db64cf6e3c37f232b5a9bceb2b6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a010c7b) will **decrease** coverage by `3.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/gobblin/pull/3376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3376 +/- ##
============================================
- Coverage 46.42% 43.03% -3.40%
+ Complexity 10156 1957 -8199
============================================
Files 2056 395 -1661
Lines 80084 16952 -63132
Branches 8948 2090 -6858
============================================
- Hits 37182 7295 -29887
+ Misses 39451 8847 -30604
+ Partials 3451 810 -2641
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/gobblin/pull/3376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `32.23% <0.00%> (-5.79%)` | :arrow_down: |
|
[...apache/gobblin/runtime/api/JobCatalogListener.java](https://codecov.io/gh/apache/gobblin/pull/3376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkNhdGFsb2dMaXN0ZW5lci5qYXZh)
| | |
|
[...e/avro/AvroKeyRecursiveCombineFileInputFormat.java](https://codecov.io/gh/apache/gobblin/pull/3376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL2F2cm8vQXZyb0tleVJlY3Vyc2l2ZUNvbWJpbmVGaWxlSW5wdXRGb3JtYXQuamF2YQ==)
| | |
|
[.../gobblin/compaction/verify/CompactionVerifier.java](https://codecov.io/gh/apache/gobblin/pull/3376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vdmVyaWZ5L0NvbXBhY3Rpb25WZXJpZmllci5qYXZh)
| | |
|
[...ervice/modules/orchestration/TimingEventUtils.java](https://codecov.io/gh/apache/gobblin/pull/3376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL1RpbWluZ0V2ZW50VXRpbHMuamF2YQ==)
| | |
|
[...paction/action/CompactionGMCEPublishingAction.java](https://codecov.io/gh/apache/gobblin/pull/3376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25HTUNFUHVibGlzaGluZ0FjdGlvbi5qYXZh)
| | |
|
[...blin/data/management/retention/DatasetCleaner.java](https://codecov.io/gh/apache/gobblin/pull/3376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9EYXRhc2V0Q2xlYW5lci5qYXZh)
| | |
|
[...onverter/avro/JsonIntermediateToAvroConverter.java](https://codecov.io/gh/apache/gobblin/pull/3376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0pzb25JbnRlcm1lZGlhdGVUb0F2cm9Db252ZXJ0ZXIuamF2YQ==)
| | |
|
[.../extractor/extract/kafka/UniversalKafkaSource.java](https://codecov.io/gh/apache/gobblin/pull/3376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9Vbml2ZXJzYWxLYWZrYVNvdXJjZS5qYXZh)
| | |
|
[...g/apache/gobblin/runtime/cli/JobStateStoreCLI.java](https://codecov.io/gh/apache/gobblin/pull/3376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvY2xpL0pvYlN0YXRlU3RvcmVDTEkuamF2YQ==)
| | |
| ... and [1653
more](https://codecov.io/gh/apache/gobblin/pull/3376/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3376?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3376?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[a010c7b...655b595](https://codecov.io/gh/apache/gobblin/pull/3376?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 641996)
Time Spent: 20m (was: 10m)
> Fix bug where FlowConfigV2ResourceHandler is being casted to
> FlowConfigResourceHandler
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1525
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1525
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Continuation from this PR https://github.com/apache/gobblin/pull/3373
> The FlowConfigV2ResourceHandler is being casted to FlowConfigResourceHandler,
> which still leads to a classcastexception when fetching the response as they
> are not backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
