vikrambohra commented on a change in pull request #3385:
URL: https://github.com/apache/gobblin/pull/3385#discussion_r704669944
##########
File path:
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriter.java
##########
@@ -148,6 +158,28 @@
/* one of the fields in DataFile entry to describe the location URI of a
data file with FS Scheme */
private static final String ICEBERG_FILE_PATH_COLUMN =
DataFile.FILE_PATH.name();
+ public static final String ICEBERG_COMPLETENESS_ENABLED =
"iceberg.completeness.enabled";
+ private static final boolean DEFAULT_ICEBERG_COMPLETENESS = false;
+ private final boolean completenessEnabled;
Review comment:
I don't understand this comment. Do you mean to move this to a separate
class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]