[
https://issues.apache.org/jira/browse/GOBBLIN-1533?focusedWorklogId=648265&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648265
]
ASF GitHub Bot logged work on GOBBLIN-1533:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/21 23:11
Start Date: 08/Sep/21 23:11
Worklog Time Spent: 10m
Work Description: vikrambohra commented on a change in pull request #3385:
URL: https://github.com/apache/gobblin/pull/3385#discussion_r704835919
##########
File path:
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriter.java
##########
@@ -671,14 +796,29 @@ public void flush(String dbName, String tableName) throws
IOException {
TableMetadata tableMetadata = tableMetadataMap.getOrDefault(tid, new
TableMetadata());
if (tableMetadata.transaction.isPresent()) {
Transaction transaction = tableMetadata.transaction.get();
+ Map<String, String> props = tableMetadata.newProperties.or(
+
Maps.newHashMap(tableMetadata.lastProperties.or(getIcebergTable(tid).properties())));
if (tableMetadata.appendFiles.isPresent()) {
tableMetadata.appendFiles.get().commit();
+ if(tableMetadata.completenessEnabled) {
+ String topicName = props.get(TOPIC_NAME_KEY);
+ if(topicName == null) {
+ log.error(String.format("Not performing audit check. %s is null.
Please set as table property of %s.%s",
+ TOPIC_NAME_KEY, dbName, tableName));
+ } else {
+ long newCompletenessWatermark =
Review comment:
This cannot be done without using the current hour of the day.
So you are suggesting something like if(datepartition > previousWatermark &&
currentHour > datepartitionHour)
if prevWatermark = 9am
datepartition = 10am
currentHour = 10am (do not check audit system) vs 11 am (check audit system
because GMIP may be lagging)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 648265)
Time Spent: 5h (was: 4h 50m)
> Add Completeness watermark to iceberg table
> -------------------------------------------
>
> Key: GOBBLIN-1533
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1533
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
