aplex commented on a change in pull request #3404:
URL: https://github.com/apache/gobblin/pull/3404#discussion_r717015820
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-api/src/main/idl/org.apache.gobblin.service.flowexecutions.restspec.json
##########
@@ -22,7 +22,6 @@
"name" : "latestFlowExecution",
"parameters" : [ {
"name" : "flowId",
- "doc" : "Retrieve the most recent matching FlowExecution(s) of the
identified FlowId",
Review comment:
This file is auto-generated, and I guess this line was added to it
manually previously. I've added javadocs to java interface, and those doc
comments came back.
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResource.java
##########
@@ -59,14 +59,16 @@ public FlowExecution get(ComplexResourceKey<FlowStatusId,
EmptyRecord> key) {
@Finder("latestFlowExecution")
public List<FlowExecution> getLatestFlowExecution(@Context PagingContext
context, @QueryParam("flowId") FlowId flowId,
- @Optional @QueryParam("count") Integer count, @Optional
@QueryParam("tag") String tag, @Optional @QueryParam("executionStatus") String
executionStatus) {
- return this.flowExecutionResourceHandler.getLatestFlowExecution(context,
flowId, count, tag, executionStatus);
+ @Optional @QueryParam("count") Integer count, @Optional
@QueryParam("tag") String tag, @Optional @QueryParam("executionStatus") String
executionStatus,
+ @Optional("false") @QueryParam("includeIssues") Boolean includeIssues) {
+ return this.flowExecutionResourceHandler.getLatestFlowExecution(context,
flowId, count, tag, executionStatus,includeIssues);
Review comment:
Hmm, I guess our automated style checks are still not some issues.
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResource.java
##########
@@ -59,14 +59,16 @@ public FlowExecution get(ComplexResourceKey<FlowStatusId,
EmptyRecord> key) {
@Finder("latestFlowExecution")
public List<FlowExecution> getLatestFlowExecution(@Context PagingContext
context, @QueryParam("flowId") FlowId flowId,
- @Optional @QueryParam("count") Integer count, @Optional
@QueryParam("tag") String tag, @Optional @QueryParam("executionStatus") String
executionStatus) {
- return this.flowExecutionResourceHandler.getLatestFlowExecution(context,
flowId, count, tag, executionStatus);
+ @Optional @QueryParam("count") Integer count, @Optional
@QueryParam("tag") String tag, @Optional @QueryParam("executionStatus") String
executionStatus,
+ @Optional("false") @QueryParam("includeIssues") Boolean includeIssues) {
+ return this.flowExecutionResourceHandler.getLatestFlowExecution(context,
flowId, count, tag, executionStatus,includeIssues);
Review comment:
Hmm, I guess our automated style checks are still not catching some
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
