umustafi commented on a change in pull request #3410:
URL: https://github.com/apache/gobblin/pull/3410#discussion_r726522250
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/dataset/FSDatasetDescriptor.java
##########
@@ -89,6 +89,12 @@ public FSDatasetDescriptor(Config config) throws IOException
{
protected boolean isPathContaining(DatasetDescriptor other) {
String otherPath = other.getPath();
String otherSubPaths = ((FSDatasetDescriptor) other).getSubPaths();
+
+ // This allows the special case where "other" is a glob, but is also an
exact match with "this" path.
+ if (getPath().equals(otherPath)) {
Review comment:
The 'matches' function for GlobPattern expects an absolute path (not a
glob), so if we were to allow 'other' to be a glob, the glob path to glob path
comparison would need to be more complex, so although this works we may want to
explicitly add the case of input = output when both are globs. Does that track?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
