ZihanLi58 opened a new pull request #3412: URL: https://github.com/apache/gobblin/pull/3412
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1561 ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): When flow compilation fails, it prints a large list of irrelevant configs that are missing from different edges. The reason for this is that the pathfinding does not know what the intended path was, so it doesn't know which edges were actually missing required config. For example, this create flow command: curli --dv-auth SELF --fabric ei-ltx1 "d2://sharedFlowconfigsV2" -X POST -H 'X-RestLi-Method: create' -H 'X-RestLi-Protocol-Version: 2.0.0' --data '{"id": {"flowName": "test123", "flowGroup": "test123"}, "properties": {"gobblin.flow.sourceIdentifier": "faro", "gobblin.flow.destinationIdentifier": "faro", "user.to.proxy": "gobblintest", "gobblin.flow.input.dataset.descriptor.path": "/tmp/gaas-cli-test/a", "gobblin.flow.output.dataset.descriptor.path": "/tmp/gaas-cli-test/a", "gobblin.flow.input.dataset.descriptor.partition.type": "none", "gobblin.flow.output.dataset.descriptor.partition.type": "none", "report.job.progress": "true", "flow.applyRetention": "true", "flow.applyInputRetention": "true", "gobblin.retention.newestK.versions.retained": "0", "dataset.datetimePattern": "yyyy/MM/dd", "copy.date.pattern": "yyyy/MM/dd"}, "templateUris": "FS:///"}' Fails because the "version.finder" property is unresolved for the faro_faro_retention edge, but that info is buried in this large error message: "Flow was not compiled successfully. Compilation errors encountered: [Error compiling edge faro_azureLnkdKtwoAdls2_inter-cluster-datetime-file-based-gen2-copy-azure: com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could not resolve substitution to a value: ${azure.container}, Error compiling edge faro_azureLnkdAdls2_single-hop-selfserve-unixts-file-based-gen2-copy-azure: com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could not resolve substitution to a value: ${azure.container}, Error compiling edge faro_azureScusAdls2-data_inter-cluster-file-based-copy-azure: com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 10: Could not resolve substitution to a value: ${destination.adl.token.type}, Error compiling edge faro_azureLnkdArchAdls2_inter-cluster-file-based-gen2-copy-azure: com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could not resolve substitution to a value: ${azure.container}, Error compilin g edge faro_azureLnkdAdls2_single-hop-selfserve-timeaware-file-based-gen2-copy-azure: com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could not resolve substitution to a value: ${azure.container}, Error compiling edge faro_faro_retention: com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 67: Could not resolve substitution to a value: ${version.finder}, No path found from source: faro and destination: faro, Error compiling edge faro_azureLnkdArchAdls2_inter-cluster-datetime-file-based-gen2-copy-azure: com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could not resolve substitution to a value: ${azure.container}, Error compiling edge faro_azureLnkdAdls2_single-hop-selfserve-glob-file-based-gen2-copy-azure: com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could not resolve substitution to a value: ${azure.container}, Error compiling edge faro_azureLnkdKtwoAdls2_inter-cluster-file-based-gen2-copy-azure: com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could not resolve substitution to a value: ${azure.container}, Error compiling edge faro_azureLnkdKtwoAdls2_inter-cluster-regex-file-based-gen2-copy-azure: com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could not resolve substitution to a value: ${azure.container}]" ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: After the change, error message changes to: "message": "Flow was not compiled successfully. Compilation errors encountered (Sorted by relevance): ERROR[0]Error compiling edge faro_faro_retention: com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 67: Could not resolve substitution to a value: ${version.finder} ERROR[1]No path found from source: faro and destination: faro ERROR[2]Error compiling edge faro_azureLnkdKtwoAdls2_inter-cluster-file-based-gen2-copy-azure: com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could not resolve substitution to a value: ${azure.container} ERROR[3]Error compiling edge faro_azureLnkdArchAdls2_inter-cluster-file-based-gen2-copy-azure: com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could not resolve substitution to a value: ${azure.container}", ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
