abhisheknath2011 opened a new pull request #3413: URL: https://github.com/apache/gobblin/pull/3413
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-XXX ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): - [ ] Leverages AvroCompatibilityHelper to upgrade to Avro 1.9.2 - [ ] With Avro 1.9 Type with "null" union is adding "default: null". This was not generated and validated by earlier version. Corrected the input test schemas/files and fixed the failed tests. - [ ] Union with default union name fails as Avro 1.9.2 uses internal JacksonUtils to convert to corresponding JsonNode and it does not support enumString as default. - [ ] Some failed tests are fixed and added todo list for some of the failed tests. The reason for this failure is due to Helix, Hadoop, Hive libraries are using older Jackson version. - [ ] Reference PR - https://github.com/apache/gobblin/pull/3328 (Initial Avro upgrade investigation PR) Avro 1.9 compatible change done earlier: - [ ] Replace the public APIs which are deprecated/removed with the ones compatible with Avro 1.9 - https://github.com/apache/gobblin/pull/3349 (Done) - [ ] Upgrade jackson mapper from 1.x to 2.x compatible with Avro 1.9 - https://github.com/apache/gobblin/pull/3368 (Done) ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
