ZihanLi58 commented on a change in pull request #3416:
URL: https://github.com/apache/gobblin/pull/3416#discussion_r732068920



##########
File path: 
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/reporter/EventReporter.java
##########
@@ -144,9 +145,11 @@ public void notificationCallback(Notification 
notification) {
    */
   public void addEventToReportingQueue(GobblinTrackingEvent event) {

Review comment:
       Not sure if I follow here, I actually make the change inside 
EventReporter, so all event reporter class should be able print the log. And 
yes, we are not using FileFailureEventReporter, the real reporter we are using 
is KafkaEventReporter




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to