[
https://issues.apache.org/jira/browse/GOBBLIN-1563?focusedWorklogId=667197&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667197
]
ASF GitHub Bot logged work on GOBBLIN-1563:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/21 18:58
Start Date: 19/Oct/21 18:58
Worklog Time Spent: 10m
Work Description: phet commented on a change in pull request #3416:
URL: https://github.com/apache/gobblin/pull/3416#discussion_r732157356
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java
##########
@@ -103,18 +101,13 @@ private String getErrorMessage(FlowSpec flowSpec) {
StringBuilder message = new StringBuilder("Flow was not compiled
successfully.");
if (!flowSpec.getCompilationErrors().isEmpty()) {
message.append(" Compilation errors encountered (Sorted by relevance):
");
- Object[] errors = flowSpec.getCompilationErrors().toArray();
+ Object[] errors =
flowSpec.getCompilationErrors().stream().distinct().toArray(FlowSpec.CompilationError[]::new);
Review comment:
don't you get a `FS.CE[]`, rather than `Object[]`, and can avoid the
cast later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 667197)
Time Spent: 2.5h (was: 2h 20m)
> Collect more information to analyze the RC for some job cannot emit kafka
> events to update job status
> -----------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1563
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1563
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Add more log in Gobblin Metrics to collect info about why we see kafka events
> missing in some case
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
