[
https://issues.apache.org/jira/browse/GOBBLIN-1557?focusedWorklogId=669675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-669675
]
ASF GitHub Bot logged work on GOBBLIN-1557:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Oct/21 17:45
Start Date: 25/Oct/21 17:45
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3408:
URL: https://github.com/apache/gobblin/pull/3408#issuecomment-943784603
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3408?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3408](https://codecov.io/gh/apache/gobblin/pull/3408?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(407daf1) into
[master](https://codecov.io/gh/apache/gobblin/commit/384dc096da8b7f05447be68fa001fcba39d64276?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(384dc09) will **increase** coverage by `2.46%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/gobblin/pull/3408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3408 +/- ##
============================================
+ Coverage 46.52% 48.99% +2.46%
+ Complexity 10246 8789 -1457
============================================
Files 2063 1683 -380
Lines 80475 65073 -15402
Branches 8989 7471 -1518
============================================
- Hits 37443 31884 -5559
+ Misses 39567 30169 -9398
+ Partials 3465 3020 -445
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/gobblin/pull/3408/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `40.00% <0.00%> (-20.00%)` | :arrow_down: |
|
[...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3408/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXIuamF2YQ==)
| `67.04% <0.00%> (-14.33%)` | :arrow_down: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/gobblin/pull/3408/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0.00%> (-7.15%)` | :arrow_down: |
|
[...che/gobblin/cluster/FsJobConfigurationManager.java](https://codecov.io/gh/apache/gobblin/pull/3408/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvRnNKb2JDb25maWd1cmF0aW9uTWFuYWdlci5qYXZh)
| `66.66% <0.00%> (-4.45%)` | :arrow_down: |
|
[...apache/gobblin/metrics/reporter/EventReporter.java](https://codecov.io/gh/apache/gobblin/pull/3408/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9FdmVudFJlcG9ydGVyLmphdmE=)
| `56.16% <0.00%> (-3.26%)` | :arrow_down: |
|
[.../java/org/apache/gobblin/runtime/api/FlowSpec.java](https://codecov.io/gh/apache/gobblin/pull/3408/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0Zsb3dTcGVjLmphdmE=)
| `40.93% <0.00%> (-2.72%)` | :arrow_down: |
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3408/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `60.21% <0.00%> (-2.16%)` | :arrow_down: |
|
[...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3408/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh)
| `59.11% <0.00%> (-2.00%)` | :arrow_down: |
|
[...lin/service/modules/flow/MultiHopFlowCompiler.java](https://codecov.io/gh/apache/gobblin/pull/3408/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93L011bHRpSG9wRmxvd0NvbXBpbGVyLmphdmE=)
| `69.87% <0.00%> (-0.83%)` | :arrow_down: |
|
[...va/org/apache/gobblin/runtime/SourceDecorator.java](https://codecov.io/gh/apache/gobblin/pull/3408/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvU291cmNlRGVjb3JhdG9yLmphdmE=)
| `41.02% <0.00%> (-0.16%)` | :arrow_down: |
| ... and [385
more](https://codecov.io/gh/apache/gobblin/pull/3408/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3408?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3408?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[384dc09...407daf1](https://codecov.io/gh/apache/gobblin/pull/3408?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 669675)
Time Spent: 1h 20m (was: 1h 10m)
> Make KafkaSource getFilteredTopics method public
> -------------------------------------------------
>
> Key: GOBBLIN-1557
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1557
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Reporter: Joseph Allemandou
> Assignee: Shirshanka Das
> Priority: Trivial
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The method is private, and it is useful to be able to override it in a
> subclass to redefine how to get topics to be processed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
