[
https://issues.apache.org/jira/browse/GOBBLIN-1567?focusedWorklogId=669678&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-669678
]
ASF GitHub Bot logged work on GOBBLIN-1567:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Oct/21 17:50
Start Date: 25/Oct/21 17:50
Worklog Time Spent: 10m
Work Description: phet commented on a change in pull request #3418:
URL: https://github.com/apache/gobblin/pull/3418#discussion_r735828590
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/db/ServiceDatabaseProviderImpl.java
##########
@@ -70,7 +70,6 @@ private synchronized void ensureDataSource() {
// To improve performance, we only check connections on creation, and set
a maximum connection lifetime
// If database goes to read-only mode, then connection would not work
correctly for up to configured lifetime
dataSource.setTestOnCreate(true);
-
dataSource.setMaxConnLifetimeMillis(configuration.getMaxConnectionLifetime().toMillis());
Review comment:
your PR description mentions that -1 means no max lifetime. would it be
desirable here to still invoke `setMaxConnLifetimeMillis`, but to have config
pass in -1 (so it's effectively disabled)? that way, with no code change
required, only config change, we could still in the future set a lifetime max
value. could that be potentially helpful, or are you certain that we'd never
wish to constrain by any max lifetime value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 669678)
Remaining Estimate: 0h
Time Spent: 10m
> do not set a custom maxConnLifetime for sql connection
> ------------------------------------------------------
>
> Key: GOBBLIN-1567
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1567
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
