[
https://issues.apache.org/jira/browse/GOBBLIN-1558?focusedWorklogId=674506&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-674506
]
ASF GitHub Bot logged work on GOBBLIN-1558:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Nov/21 10:29
Start Date: 03/Nov/21 10:29
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on pull request #3409:
URL: https://github.com/apache/gobblin/pull/3409#issuecomment-958850339
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3409?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3409](https://codecov.io/gh/apache/gobblin/pull/3409?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(efc2ff1) into
[master](https://codecov.io/gh/apache/gobblin/commit/384dc096da8b7f05447be68fa001fcba39d64276?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(384dc09) will **decrease** coverage by `3.34%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/gobblin/pull/3409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3409 +/- ##
============================================
- Coverage 46.52% 43.17% -3.35%
+ Complexity 10246 2006 -8240
============================================
Files 2063 401 -1662
Lines 80475 17275 -63200
Branches 8989 2121 -6868
============================================
- Hits 37443 7459 -29984
+ Misses 39567 8978 -30589
+ Partials 3465 838 -2627
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/gobblin/pull/3409/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `40.00% <0.00%> (-20.00%)` | :arrow_down: |
|
[...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3409/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXIuamF2YQ==)
| `67.04% <0.00%> (-14.33%)` | :arrow_down: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/gobblin/pull/3409/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0.00%> (-7.15%)` | :arrow_down: |
|
[...che/gobblin/cluster/FsJobConfigurationManager.java](https://codecov.io/gh/apache/gobblin/pull/3409/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvRnNKb2JDb25maWd1cmF0aW9uTWFuYWdlci5qYXZh)
| `66.66% <0.00%> (-4.45%)` | :arrow_down: |
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3409/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `60.21% <0.00%> (-2.16%)` | :arrow_down: |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3409/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `63.46% <0.00%> (-0.33%)` | :arrow_down: |
|
[...apache/gobblin/salesforce/SalesforceExtractor.java](https://codecov.io/gh/apache/gobblin/pull/3409/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZUV4dHJhY3Rvci5qYXZh)
| `0.00% <0.00%> (ø)` | |
|
[...rg/apache/gobblin/publisher/BaseDataPublisher.java](https://codecov.io/gh/apache/gobblin/pull/3409/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9CYXNlRGF0YVB1Ymxpc2hlci5qYXZh)
| | |
|
[...obblin/publisher/TimePartitionedDataPublisher.java](https://codecov.io/gh/apache/gobblin/pull/3409/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9UaW1lUGFydGl0aW9uZWREYXRhUHVibGlzaGVyLmphdmE=)
| | |
|
[...blisher/TimePartitionedStreamingDataPublisher.java](https://codecov.io/gh/apache/gobblin/pull/3409/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9UaW1lUGFydGl0aW9uZWRTdHJlYW1pbmdEYXRhUHVibGlzaGVyLmphdmE=)
| | |
| ... and [1660
more](https://codecov.io/gh/apache/gobblin/pull/3409/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3409?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3409?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[384dc09...efc2ff1](https://codecov.io/gh/apache/gobblin/pull/3409?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 674506)
Time Spent: 1h 10m (was: 1h)
> Overwrite BaseDataPublisher behavior when parent-folder doesn't exist and use
> it in TimePartitionedDataPublisher
> ----------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1558
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1558
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: Joseph Allemandou
> Assignee: Abhishek Tiwari
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> It's currently not possible to overwrite the behavior of the publisher when
> publishing to non-existing parent directory (first run of job type for
> instance). This would be needed to make TimePartitionDataPublisher save
> recordPublisherOutputDirs at lowest granularity (detailed subfolders).
>
> BaseDataPublisher: Extract new method `addWriterOutputToNewDir` that goes
> with the already existing `addWriterOutputToExistingDir`. No test needed, the
> code is no-op on class behavior.
> TimePartitionedDataPublisher: Override the new `addWriterOutputToNewDir`
> method to create the publisher parent folder and reuse the
> `addWriterOutputToExistingDir` method. Rename and update
> TimePartitionedStreamingDataPublisherTest class to actually test
> TimePartitionedDataPublisher.
> TimePartitionedStreamingDataPublisher: Remove publisher parent folder
> creation as it managed in TimePartitionedDataPublisher superclass. Add test
> based on the copied TimePartitionedStreamingDataPublisherTest to verify the
> change also works for this child class.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
