arjun4084346 commented on a change in pull request #3403:
URL: https://github.com/apache/gobblin/pull/3403#discussion_r743152112
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/FsJobStatusRetriever.java
##########
@@ -60,7 +62,8 @@
@Inject
public FsJobStatusRetriever(Config config, MultiContextIssueRepository
issueRepository) {
- super(issueRepository);
+ super(ConfigUtils.getBoolean(config,
ServiceConfigKeys.GOBBLIN_SERVICE_DAG_MANAGER_ENABLED_KEY,
+ ServiceConfigKeys.DEFAULT_GOBBLIN_SERVICE_DAG_MANAGER_ENABLED),
issueRepository);
Review comment:
Yes, I would prefer to leave it like this. If in future we need more
params to be passed, we again have to change the signature/DI logic. We already
need other configs in the next line to create a state store
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
