arjun4084346 commented on a change in pull request #3423:
URL: https://github.com/apache/gobblin/pull/3423#discussion_r743103523
##########
File path:
gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/azkaban/AzkabanJobLauncher.java
##########
@@ -379,7 +380,8 @@ private boolean isCurrentTimeInRange() {
private static List<? extends Tag<?>> addAdditionalMetadataTags(Properties
jobProps) {
List<Tag<?>> metadataTags = Lists.newArrayList();
String jobExecutionId = jobProps.getProperty(AZKABAN_FLOW_EXEC_ID, "");
- String jobExecutionUrl = jobProps.getProperty(AZKABAN_LINK_JOBEXEC_URL,
"");
+ // Display the proxy URL in the metadata tag if it exists
+ String jobExecutionUrl =
jobProps.getProperty(AZKABAN_LINK_JOBEXEC_PROXY_URL,
jobProps.getProperty(AZKABAN_LINK_JOBEXEC_URL, ""));
Review comment:
Does it make sense to consider adding both `jobExecutionUrl` and
`jobExecutionProxyUrl` if exists?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
