[
https://issues.apache.org/jira/browse/GOBBLIN-1576?focusedWorklogId=682349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-682349
]
ASF GitHub Bot logged work on GOBBLIN-1576:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/21 00:41
Start Date: 17/Nov/21 00:41
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3429:
URL: https://github.com/apache/gobblin/pull/3429#issuecomment-970871317
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3429?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3429](https://codecov.io/gh/apache/gobblin/pull/3429?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(91c3adf) into
[master](https://codecov.io/gh/apache/gobblin/commit/5bc22a5502ddeb810a35b0fb996dd9dfc8c81121?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(5bc22a5) will **increase** coverage by `5.13%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/gobblin/pull/3429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3429 +/- ##
============================================
+ Coverage 43.29% 48.42% +5.13%
- Complexity 2017 7690 +5673
============================================
Files 402 1437 +1035
Lines 17325 56777 +39452
Branches 2121 6539 +4418
============================================
+ Hits 7500 27493 +19993
- Misses 8987 26719 +17732
- Partials 838 2565 +1727
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...n/java/org/apache/gobblin/writer/FsDataWriter.java](https://codecov.io/gh/apache/gobblin/pull/3429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9Gc0RhdGFXcml0ZXIuamF2YQ==)
| `75.00% <0.00%> (ø)` | |
|
[...util/recordcount/IngestionRecordCountProvider.java](https://codecov.io/gh/apache/gobblin/pull/3429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvcmVjb3JkY291bnQvSW5nZXN0aW9uUmVjb3JkQ291bnRQcm92aWRlci5qYXZh)
| `88.88% <66.66%> (+3.17%)` | :arrow_up: |
|
[.../java/org/apache/gobblin/cluster/SleepingTask.java](https://codecov.io/gh/apache/gobblin/pull/3429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2xlZXBpbmdUYXNrLmphdmE=)
| `39.39% <0.00%> (-6.07%)` | :arrow_down: |
|
[.../source/extractor/filebased/CsvFileDownloader.java](https://codecov.io/gh/apache/gobblin/pull/3429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZmlsZWJhc2VkL0NzdkZpbGVEb3dubG9hZGVyLmphdmE=)
| `0.00% <0.00%> (ø)` | |
|
[...gobblin/writer/http/AbstractHttpWriterBuilder.java](https://codecov.io/gh/apache/gobblin/pull/3429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9odHRwL0Fic3RyYWN0SHR0cFdyaXRlckJ1aWxkZXIuamF2YQ==)
| `52.94% <0.00%> (ø)` | |
|
[...in/java/org/apache/gobblin/hive/HivePartition.java](https://codecov.io/gh/apache/gobblin/pull/3429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL0hpdmVQYXJ0aXRpb24uamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[...blin/data/management/retention/DatasetCleaner.java](https://codecov.io/gh/apache/gobblin/pull/3429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9EYXRhc2V0Q2xlYW5lci5qYXZh)
| `0.00% <0.00%> (ø)` | |
|
[...he/gobblin/runtime/FsDatasetStateStoreFactory.java](https://codecov.io/gh/apache/gobblin/pull/3429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvRnNEYXRhc2V0U3RhdGVTdG9yZUZhY3RvcnkuamF2YQ==)
| `50.00% <0.00%> (ø)` | |
|
[...he/gobblin/policies/avro/AvroHeaderGuidPolicy.java](https://codecov.io/gh/apache/gobblin/pull/3429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3BvbGljaWVzL2F2cm8vQXZyb0hlYWRlckd1aWRQb2xpY3kuamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[...e/gobblin/converter/json/BytesToJsonConverter.java](https://codecov.io/gh/apache/gobblin/pull/3429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9qc29uL0J5dGVzVG9Kc29uQ29udmVydGVyLmphdmE=)
| `62.50% <0.00%> (ø)` | |
| ... and [1030
more](https://codecov.io/gh/apache/gobblin/pull/3429/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3429?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3429?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[5bc22a5...91c3adf](https://codecov.io/gh/apache/gobblin/pull/3429?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 682349)
Time Spent: 1h (was: 50m)
> Skip renaming of recordcount to staging file if it already exists
> -----------------------------------------------------------------
>
> Key: GOBBLIN-1576
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1576
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
