arjun4084346 commented on a change in pull request #3427:
URL: https://github.com/apache/gobblin/pull/3427#discussion_r750797627



##########
File path: 
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixRetriggeringJobCallable.java
##########
@@ -263,7 +275,7 @@ private void runJobExecutionLauncher() throws JobException {
       jobLock.lock();
 
       try {
-        if (planningJobIdFromStore.isPresent() && 
!canRun(planningJobIdFromStore.get(), planningJobManager)) {
+        if (planningJobIdFromStore.isPresent() && 
!canRun(planningJobIdFromStore.get(), planningJobHelixManager)) {

Review comment:
       Actually I tried that, here and at other place. But because the map 
Function does not expect to throw an exception, it does not end up as clean as 
this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to