[jira] [Created] (GOBBLIN-1578) deregistration of hive table should not delete data

[Arjun Singh Bora (Jira)]

Arjun Singh Bora created GOBBLIN-1578:
-----------------------------------------

             Summary: deregistration of hive table should not delete data
                 Key: GOBBLIN-1578
                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1578
             Project: Apache Gobblin
          Issue Type: Bug
            Reporter: Arjun Singh Bora


I found that Gobblin actually is not respecting the config 
hive.dataset.copy.deregister.fileDeleteMethod for unpartitioned tables
Here we call dropTable with default params 
[https://github.com/apache/gobblin/blob/master/gobblin-hive-registration/src/main/j[…]g/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java|https://github.com/apache/gobblin/blob/master/gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java#L528],
 which deletes the data as well. We should be calling it with deleteData=false 
like in 
[https://github.com/apache/gobblin/blob/master/gobblin-hive-registration/src/main/j[…]g/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java|https://github.com/apache/gobblin/blob/master/gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java#L549]
 
 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)