[
https://issues.apache.org/jira/browse/GOBBLIN-1578?focusedWorklogId=683041&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-683041
]
ASF GitHub Bot logged work on GOBBLIN-1578:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/21 02:15
Start Date: 18/Nov/21 02:15
Worklog Time Spent: 10m
Work Description: Will-Lo commented on a change in pull request #3431:
URL: https://github.com/apache/gobblin/pull/3431#discussion_r751829639
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##########
@@ -68,7 +65,10 @@
import org.apache.gobblin.metrics.GobblinMetricsRegistry;
import org.apache.gobblin.metrics.MetricContext;
import org.apache.gobblin.metrics.event.EventSubmitter;
+import org.apache.gobblin.metrics.kafka.KafkaSchemaRegistry;
+import org.apache.gobblin.source.extractor.extract.kafka.KafkaSource;
import org.apache.gobblin.util.AutoReturnableObject;
+import org.apache.gobblin.util.AvroUtils;
Review comment:
Were all these import changes caused by intellij autoformat?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 683041)
Time Spent: 20m (was: 10m)
> deregistration of hive table should not delete data
> ---------------------------------------------------
>
> Key: GOBBLIN-1578
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1578
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I found that Gobblin actually is not respecting the config
> hive.dataset.copy.deregister.fileDeleteMethod for unpartitioned tables
> Here we call dropTable with default params
> [https://github.com/apache/gobblin/blob/master/gobblin-hive-registration/src/main/j[…]g/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java|https://github.com/apache/gobblin/blob/master/gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java#L528],
> which deletes the data as well. We should be calling it with
> deleteData=false like in
> [https://github.com/apache/gobblin/blob/master/gobblin-hive-registration/src/main/j[…]g/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java|https://github.com/apache/gobblin/blob/master/gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java#L549]
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
