phet commented on a change in pull request #3430:
URL: https://github.com/apache/gobblin/pull/3430#discussion_r751825712
##########
File path:
gobblin-utility/src/main/java/org/apache/gobblin/util/retry/RetryerFactory.java
##########
@@ -127,7 +124,7 @@ public boolean apply(Throwable t) {
return RetryerBuilder.<T> newBuilder()
.retryIfException(RETRY_EXCEPTION_PREDICATE)
.withWaitStrategy(WaitStrategies.exponentialWait(config.getLong(RETRY_MULTIPLIER),
-
config.getLong(RETRY_INTERVAL_MS),
+
config.getLong(RETRY_MAX_INTERVAL_MS),
Review comment:
doesn't this break backward compatibility?
first off, I prefer your new name to the existing one... but existing code
out there is setting `RETRY_MULTIPLIER_MS` and that no longer means anything
for EB--which is the default strategy. I'd say it's too late to change naming.
less severely, but since this is a general library, is it possible certain
existing clients aren't on such a large time-scale and would instead consider
seconds (rather than ms) way too long?
...or do you think I'm being too conservative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
