[
https://issues.apache.org/jira/browse/GOBBLIN-1580?focusedWorklogId=683740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-683740
]
ASF GitHub Bot logged work on GOBBLIN-1580:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/21 01:31
Start Date: 19/Nov/21 01:31
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on pull request #3432:
URL: https://github.com/apache/gobblin/pull/3432#issuecomment-973645986
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3432?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3432](https://codecov.io/gh/apache/gobblin/pull/3432?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(cd43b15) into
[master](https://codecov.io/gh/apache/gobblin/commit/5bc22a5502ddeb810a35b0fb996dd9dfc8c81121?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(5bc22a5) will **increase** coverage by `3.28%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/gobblin/pull/3432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3432 +/- ##
============================================
+ Coverage 43.29% 46.57% +3.28%
- Complexity 2017 10322 +8305
============================================
Files 402 2071 +1669
Lines 17325 80843 +63518
Branches 2121 9020 +6899
============================================
+ Hits 7500 37652 +30152
- Misses 8987 39707 +30720
- Partials 838 3484 +2646
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/gobblin/pull/3432/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh)
| `10.66% <0.00%> (ø)` | |
|
[.../java/org/apache/gobblin/cluster/SleepingTask.java](https://codecov.io/gh/apache/gobblin/pull/3432/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2xlZXBpbmdUYXNrLmphdmE=)
| `39.39% <0.00%> (-6.07%)` | :arrow_down: |
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3432/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `60.21% <0.00%> (-2.16%)` | :arrow_down: |
|
[.../gobblin/iceberg/writer/IcebergMetadataWriter.java](https://codecov.io/gh/apache/gobblin/pull/3432/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0ljZWJlcmdNZXRhZGF0YVdyaXRlci5qYXZh)
| `72.18% <0.00%> (-0.12%)` | :arrow_down: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/gobblin/pull/3432/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0.00%> (ø)` | |
|
[...untime/instance/StandardGobblinInstanceDriver.java](https://codecov.io/gh/apache/gobblin/pull/3432/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvaW5zdGFuY2UvU3RhbmRhcmRHb2JibGluSW5zdGFuY2VEcml2ZXIuamF2YQ==)
| `74.13% <0.00%> (ø)` | |
|
[...apache/gobblin/yarn/GobblinYarnEventConstants.java](https://codecov.io/gh/apache/gobblin/pull/3432/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5FdmVudENvbnN0YW50cy5qYXZh)
| `0.00% <0.00%> (ø)` | |
|
[...retention/version/finder/DatasetVersionFinder.java](https://codecov.io/gh/apache/gobblin/pull/3432/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi92ZXJzaW9uL2ZpbmRlci9EYXRhc2V0VmVyc2lvbkZpbmRlci5qYXZh)
| `100.00% <0.00%> (ø)` | |
|
[.../data/management/version/StringDatasetVersion.java](https://codecov.io/gh/apache/gobblin/pull/3432/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3ZlcnNpb24vU3RyaW5nRGF0YXNldFZlcnNpb24uamF2YQ==)
| `84.61% <0.00%> (ø)` | |
|
[...tention/profile/ManagedCleanableDatasetFinder.java](https://codecov.io/gh/apache/gobblin/pull/3432/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9wcm9maWxlL01hbmFnZWRDbGVhbmFibGVEYXRhc2V0RmluZGVyLmphdmE=)
| `69.23% <0.00%> (ø)` | |
| ... and [1667
more](https://codecov.io/gh/apache/gobblin/pull/3432/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3432?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3432?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[5bc22a5...cd43b15](https://codecov.io/gh/apache/gobblin/pull/3432?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 683740)
Time Spent: 20m (was: 10m)
> Check table exists instead of call create table directly to make sure table
> exists
> ----------------------------------------------------------------------------------
>
> Key: GOBBLIN-1580
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1580
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
