arjun4084346 commented on a change in pull request #3436:
URL: https://github.com/apache/gobblin/pull/3436#discussion_r756478504
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/QueryBasedSource.java
##########
@@ -241,6 +244,14 @@ public int hashCode() {
addLineageSourceInfo(state, sourceEntity, workunit);
partition.serialize(workunit);
workUnits.add(workunit);
+ highestWaterMark = highestWaterMark.isPresent() ?
+ highestWaterMark.transform(l -> Math.max(l,
partition.getHighWatermark())) : Optional.of(partition.getHighWatermark());
Review comment:
*nit maybe `l` should be renamed to hw ?
and in next line `l` should be `lw ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
