ZihanLi58 commented on a change in pull request #3439:
URL: https://github.com/apache/gobblin/pull/3439#discussion_r762322260
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java
##########
@@ -296,6 +296,14 @@ private static void
modifyStateIfRetryRequired(org.apache.gobblin.configuration.
mergedState.putAll(fallbackState.getProperties());
mergedState.putAll(state.getProperties());
+ // Set CURRENT_ATTEMPTS_FIELD to right value to avoid continually retrying
+ if
(fallbackState.getPropAsInt(TimingEvent.FlowEventConstants.CURRENT_ATTEMPTS_FIELD,0)
> state.getPropAsInt(TimingEvent.FlowEventConstants.CURRENT_ATTEMPTS_FIELD,0))
{
Review comment:
In this case, we meet this condition and go into the "if" branch only
when fallbackState has the prop and it's larger than 0 (at least 1). But if I
set default to be one, in the situation that the fallback state does not have
the prop and state has the prop set to be 0, we will update it which is
unexpected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
