umustafi commented on a change in pull request #3438:
URL: https://github.com/apache/gobblin/pull/3438#discussion_r763348629
##########
File path:
gobblin-modules/gobblin-sql/src/main/java/org/apache/gobblin/writer/commands/BaseJdbcBufferedInserter.java
##########
@@ -80,6 +85,8 @@ public BaseJdbcBufferedInserter(State state, Connection conn)
{
this.retryer = RetryerBuilder.<Boolean> newBuilder().retryIfException()
.withWaitStrategy(WaitStrategies.exponentialWait(1000, maxWait,
TimeUnit.SECONDS))
.withStopStrategy(StopStrategies.stopAfterAttempt(maxAttempts)).build();
+
+ this.replaceExistingValues =
state.getPropAsBoolean(ConfigurationKeys.ALLOW_DATA_OVERWRITE);
Review comment:
I haven't added the "fail fast" logic in the other child classes that do
not have any functionality implemented for this. If the config is true should
the job fail in the constructor or at the time of writing `(initialize batch)`
or should I add documentation that the logic does not exist and allow the job
to succeed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
