ZihanLi58 commented on a change in pull request #3441:
URL: https://github.com/apache/gobblin/pull/3441#discussion_r764218925
##########
File path:
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/GobblinMCEWriter.java
##########
@@ -420,4 +434,22 @@ public static State setHiveRegProperties(State state,
GobblinMetadataChangeEvent
}
return tmpState;
}
+
+ /**
+ * Submit event indicating that a specific set of GMCEs have been skipped,
so there is a gap in the registration
+ */
+ private void submitFailureEvent(GobblinMetadataException exception) {
+ log.warn(String.format("Sending GTE to indicate table flush failure for
%s", exception.tableName));
Review comment:
also include the db information?
##########
File path:
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/GobblinMCEWriter.java
##########
@@ -420,4 +434,22 @@ public static State setHiveRegProperties(State state,
GobblinMetadataChangeEvent
}
return tmpState;
}
+
+ /**
+ * Submit event indicating that a specific set of GMCEs have been skipped,
so there is a gap in the registration
+ */
+ private void submitFailureEvent(GobblinMetadataException exception) {
+ log.warn(String.format("Sending GTE to indicate table flush failure for
%s", exception.tableName));
+
+ GobblinEventBuilder gobblinTrackingEvent = new
GobblinEventBuilder(IcebergMCEMetadataKeys.ICEBERG_COMMIT_EVENT_NAME);
Review comment:
Do we want to use the same event name when we successfully commit one
snapshot? Should we use another event name like METADATA_WRITER_FAILURE_EVENT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
