phet commented on a change in pull request #3448:
URL: https://github.com/apache/gobblin/pull/3448#discussion_r778499644
##########
File path:
gobblin-modules/gobblin-service-kafka/src/main/java/org/apache/gobblin/service/StreamingKafkaSpecConsumer.java
##########
@@ -111,13 +113,15 @@ public StreamingKafkaSpecConsumer(Config config,
MutableJobCatalog jobCatalog) {
try {
Pair<SpecExecutor.Verb, Spec> specPair = _jobSpecQueue.take();
- _metrics.specConsumerJobSpecDeq.mark();
+ int numSpecFetched = 0;
do {
+ _metrics.specConsumerJobSpecDeq.mark();
+ numSpecFetched ++;
changesSpecs.add(specPair);
// if there are more elements then pass them along in this call
specPair = _jobSpecQueue.poll();
- } while (specPair != null);
+ } while (specPair != null && numSpecFetched < _jobSpecQueueSize);
Review comment:
I don't fully grasp the connection between deciding to take no more
specs (for now, by breaking out of the loop) and the max number of elements the
queue could hold at one time. is it just an arbitrary value, yet being finite,
ensures termination? maybe a comment...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
