[
https://issues.apache.org/jira/browse/GOBBLIN-1593?focusedWorklogId=703702&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-703702
]
ASF GitHub Bot logged work on GOBBLIN-1593:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jan/22 02:22
Start Date: 05/Jan/22 02:22
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3448:
URL: https://github.com/apache/gobblin/pull/3448#discussion_r778506245
##########
File path:
gobblin-modules/gobblin-service-kafka/src/main/java/org/apache/gobblin/service/StreamingKafkaSpecConsumer.java
##########
@@ -111,13 +113,15 @@ public StreamingKafkaSpecConsumer(Config config,
MutableJobCatalog jobCatalog) {
try {
Pair<SpecExecutor.Verb, Spec> specPair = _jobSpecQueue.take();
- _metrics.specConsumerJobSpecDeq.mark();
+ int numSpecFetched = 0;
do {
+ _metrics.specConsumerJobSpecDeq.mark();
+ numSpecFetched ++;
changesSpecs.add(specPair);
// if there are more elements then pass them along in this call
specPair = _jobSpecQueue.poll();
- } while (specPair != null);
+ } while (specPair != null && numSpecFetched < _jobSpecQueueSize);
Review comment:
Yes, it's just to make it to be finite as I notice that during some peek
time, we may end up with continually put elements into the queue and the loop
takes a long time to finish and yet cause the job to delay. I picked this value
because queue size is configurable and I think the max batch size(spec we
fetched at one time) and the max queue capacity should be positively related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 703702)
Time Spent: 1h 10m (was: 1h)
> Fix bugs in dag manager about metric reporting and job status monitor
> ----------------------------------------------------------------------
>
> Key: GOBBLIN-1593
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1593
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We have several bugs in the dag manager
> # the number of job enqueue does not match the number of job dequeue from
> jobSprcConsumer
> # CurrentAttempts and generation are not passed to the job config correctly
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
