[
https://issues.apache.org/jira/browse/GOBBLIN-1599?focusedWorklogId=713243&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713243
]
ASF GitHub Bot logged work on GOBBLIN-1599:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/22 18:40
Start Date: 22/Jan/22 18:40
Worklog Time Spent: 10m
Work Description: pedro93 opened a new pull request #3455:
URL: https://github.com/apache/gobblin/pull/3455
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
Gobblin depended on an old deprecated Avro API that worked with Jackson
JsonNode objects. In Gobblin's default Avro dependency version (1.8) these APIs
were already marked as deprecated. In Avro 1.9 these APIs were replaced by
similar APIs that work with `Object` rather than `JsonNode` Java objects.
### Tests
My PR does not need unit tests to validate whether it is working. Simply
attempting to compile the project with a flag to inject avro 1.9+
(`-PavroVersion=1.9.1`) validates that this PR fixes the issue.
Functionally the change also worked appropriately as I was able to use newer
Avro versions to read events from Kafka using gobblin jobs that depended on
these new versions.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 713243)
Remaining Estimate: 0h
Time Spent: 10m
> Gobblin does not compile when compiled with avro version 1.9+
> -------------------------------------------------------------
>
> Key: GOBBLIN-1599
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1599
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Pedro Cardoso Silva
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Attempting to compile gobblin with an avro version 1.9 or greater fails due
> to Gobblin's usage of deprecated APIs.
> To validate this, run the build command with `-PavroVersion=1.9.1`
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
