[
https://issues.apache.org/jira/browse/GOBBLIN-1602?focusedWorklogId=721720&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-721720
]
ASF GitHub Bot logged work on GOBBLIN-1602:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/22 01:04
Start Date: 07/Feb/22 01:04
Worklog Time Spent: 10m
Work Description: Will-Lo commented on a change in pull request #3459:
URL: https://github.com/apache/gobblin/pull/3459#discussion_r800261552
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/hive/UnpartitionedTableFileSet.java
##########
@@ -64,11 +65,21 @@ public UnpartitionedTableFileSet(String name, HiveDataset
dataset, HiveCopyEntit
Optional<Table> existingTargetTable = this.helper.getExistingTargetTable();
if (existingTargetTable.isPresent()) {
- if
(!this.helper.getTargetTable().getDataLocation().equals(existingTargetTable.get().getDataLocation()))
{
+ boolean path_mismatch = false;
+ try {
+ if
(!this.helper.getTargetFs().resolvePath(this.helper.getTargetTable().getDataLocation())
+
.equals(this.helper.getTargetFs().resolvePath(existingTargetTable.get().getDataLocation())))
{
+ path_mismatch = true;
+ }
+ } catch (FileNotFoundException e) {
+ // If desired path does not exist, then user is defining a different
snapshot path so check policy
+ path_mismatch = true;
+ }
+ if (path_mismatch) {
Review comment:
Ah good suggestion, will implement it this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 721720)
Time Spent: 1h 20m (was: 1h 10m)
> Handle hive table mismatch when paths are equivalent in the underlying FS
> -------------------------------------------------------------------------
>
> Key: GOBBLIN-1602
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1602
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In scenarios where the paths are equivalent in the underlying FS, hive copy
> should not treat these paths separately if the user provided URI does not
> match the hive registered URI
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
