[
https://issues.apache.org/jira/browse/GOBBLIN-1604?focusedWorklogId=723197&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723197
]
ASF GitHub Bot logged work on GOBBLIN-1604:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/22 21:29
Start Date: 08/Feb/22 21:29
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3461:
URL: https://github.com/apache/gobblin/pull/3461#discussion_r802073840
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/CopySource.java
##########
@@ -291,6 +292,20 @@ private void
submitUnfulfilledRequestEventsHelper(List<FileSet<CopyEntity>> file
}
}
+ void failJobIfAllRequestsRejected(RequestAllocator<FileSet<CopyEntity>>
allocator,
+ Iterator<FileSet<CopyEntity>> allocatedRequests) throws IOException {
+ // TODO: we should set job as partial success if there is a mix of
allocated requests and rejections
Review comment:
I think this partial success is seen frequently as well, worth to
address.
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/CopySource.java
##########
@@ -291,6 +292,20 @@ private void
submitUnfulfilledRequestEventsHelper(List<FileSet<CopyEntity>> file
}
}
+ void failJobIfAllRequestsRejected(RequestAllocator<FileSet<CopyEntity>>
allocator,
+ Iterator<FileSet<CopyEntity>> allocatedRequests) throws IOException {
+ // TODO: we should set job as partial success if there is a mix of
allocated requests and rejections
+ if
(PriorityIterableBasedRequestAllocator.class.isAssignableFrom(allocator.getClass()))
{
+ PriorityIterableBasedRequestAllocator<FileSet<CopyEntity>>
priorityIterableBasedRequestAllocator =
+ (PriorityIterableBasedRequestAllocator<FileSet<CopyEntity>>)
allocator;
+ // If there are no allocated items and there items exceeding the
available resources, then we can infer all items exceed resources
Review comment:
If there are no allocated items and there "are" items exceeding the
available resources, then we can infer all items exceed resources?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 723197)
Time Spent: 50m (was: 40m)
> Throw Allocation Error if all attempts to allocate workunits exceeds resource
> maximums
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1604
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1604
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: William Lo
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In distcp, if the size or number of files allocated by the RequestAllocator
> during workunit collection is too large, then Gobblin will log the error:
> {code:java}
> // item does not fit even in empty pool
> log.warn(String.format("Request %s is larger than the available resource
> pool. If the pool is not expanded, "
> + "it will never be selected. Request: %s.", newElement.getT(),
> {code}
> The job will still be marked as COMMITTED/SUCCESSFUL state, when it should
> really be partial success of FAIL if there are no workunits collected, to
> make the failure more visible to users.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
