ZihanLi58 commented on a change in pull request #3461:
URL: https://github.com/apache/gobblin/pull/3461#discussion_r803237679
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/CopySource.java
##########
@@ -291,6 +292,20 @@ private void
submitUnfulfilledRequestEventsHelper(List<FileSet<CopyEntity>> file
}
}
+ void failJobIfAllRequestsRejected(RequestAllocator<FileSet<CopyEntity>>
allocator,
+ Iterator<FileSet<CopyEntity>> allocatedRequests) throws IOException {
+ // TODO: we should set job as partial success if there is a mix of
allocated requests and rejections
Review comment:
Yeah, no need to handle in this PR, but it worth to think how can we not
silent fail some datasets when the resources is not enough and at the same time
we want other dataset been processed successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
