[
https://issues.apache.org/jira/browse/GOBBLIN-1616?focusedWorklogId=735031&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735031
]
ASF GitHub Bot logged work on GOBBLIN-1616:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/22 23:24
Start Date: 01/Mar/22 23:24
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3474:
URL: https://github.com/apache/gobblin/pull/3474#discussion_r817223365
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/restapi/RestApiConnector.java
##########
@@ -77,6 +82,15 @@ public RestApiConnector(State state) {
state.getPropAsInt(ConfigurationKeys.SOURCE_CONN_TIMEOUT,
ConfigurationKeys.DEFAULT_CONN_TIMEOUT);
}
+ @Override
+ public void close() throws IOException {
Review comment:
For all restApiExtractor which may contain this connect, we expect the
closeConnection method will close the connector. Will update PR to include this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 735031)
Time Spent: 0.5h (was: 20m)
> Make RestApiConnector be able to close the connection finally
> -------------------------------------------------------------
>
> Key: GOBBLIN-1616
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1616
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In RestApiConnector, we only consume the HttpEntity but not close the
> response, which potentially leave the socket as CLOSE_WAIT status and eat up
> the resources.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
