[
https://issues.apache.org/jira/browse/GOBBLIN-1616?focusedWorklogId=747896&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747896
]
ASF GitHub Bot logged work on GOBBLIN-1616:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/22 17:26
Start Date: 25/Mar/22 17:26
Worklog Time Spent: 10m
Work Description: phet commented on a change in pull request #3486:
URL: https://github.com/apache/gobblin/pull/3486#discussion_r835472782
##########
File path:
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceSource.java
##########
@@ -223,6 +224,15 @@ protected void addLineageSourceInfo(SourceState
sourceState, SourceEntity entity
}
} catch (Exception e) {
throw new RuntimeException(e);
+ } finally {
+ if(salesforceExtractor != null) {
+ try {
+ // Only close connection here since we don't want to update the high
watermark for the workUnitState here
Review comment:
makes sense. so maybe?
```
// `.closeConnection()`, not `.close()` to avoid updating high watermark for
the workUnitState
```
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/restapi/RestApiConnector.java
##########
@@ -192,8 +190,8 @@ private static boolean hasId(JsonObject json) {
if (httpEntity != null) {
EntityUtils.consume(httpEntity);
}
- if(httpResponse instanceof CloseableHttpResponse) {
- this.closer.register((CloseableHttpResponse)httpResponse);
+ if(httpResponse instanceof Closeable) {
+ this.closer.register((Closeable)httpResponse);
Review comment:
if you on the line directly following `httpResponse` assignment (or
preferably, initialization) it's guaranteed to execute if and only if the
`httpClient.execute` returned a result normally, w/o throwing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 747896)
Time Spent: 2.5h (was: 2h 20m)
> Make RestApiConnector be able to close the connection finally
> -------------------------------------------------------------
>
> Key: GOBBLIN-1616
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1616
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> In RestApiConnector, we only consume the HttpEntity but not close the
> response, which potentially leave the socket as CLOSE_WAIT status and eat up
> the resources.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
