Will-Lo opened a new pull request, #3495: URL: https://github.com/apache/gobblin/pull/3495
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1634 ### Description - [x] Here are some details about my PR, including screenshots (if applicable): On Gobblin as a Service flows can fail SLAs if they do not receive a Kafka event in some designated amount of time. Since GaaS supports retrys on failures, these failures due to SLAs should also be retryable. However, if the flow is cancelled from a user specified event through the API we do not want to retry. Additionally, we also do not want to retry if a flow is skipped due to concurrent jobs running at the same time, as it is unlikely without a more sophisticated waiting algorithm that the job will be finished by the time the job is retried again, wasting resources. ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
