[
https://issues.apache.org/jira/browse/GOBBLIN-1634?focusedWorklogId=763369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763369
]
ASF GitHub Bot logged work on GOBBLIN-1634:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/22 08:40
Start Date: 28/Apr/22 08:40
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3495:
URL: https://github.com/apache/gobblin/pull/3495#discussion_r860624591
##########
gobblin-modules/gobblin-kafka-09/src/test/java/org/apache/gobblin/runtime/KafkaAvroJobStatusMonitorTest.java:
##########
@@ -130,78 +130,49 @@ public void testProcessMessageForSuccessfulFlow() throws
IOException, Reflective
} catch(InterruptedException ex) {
Thread.currentThread().interrupt();
}
-
- Config config =
ConfigFactory.empty().withValue(ConfigurationKeys.KAFKA_BROKERS,
ConfigValueFactory.fromAnyRef("localhost:0000"))
-
.withValue(Kafka09ConsumerClient.GOBBLIN_CONFIG_VALUE_DESERIALIZER_CLASS_KEY,
ConfigValueFactory.fromAnyRef("org.apache.kafka.common.serialization.ByteArrayDeserializer"))
- .withValue(ConfigurationKeys.STATE_STORE_ROOT_DIR_KEY,
ConfigValueFactory.fromAnyRef(stateStoreDir))
- .withValue("zookeeper.connect",
ConfigValueFactory.fromAnyRef("localhost:2121"));
- MockKafkaAvroJobStatusMonitor jobStatusMonitor = new
MockKafkaAvroJobStatusMonitor("test",config, 1);
+ MockKafkaAvroJobStatusMonitor jobStatusMonitor = createMockKAJSM(new
AtomicBoolean(false), ConfigFactory.empty());
Review Comment:
minor... and sorry, I abbreviated in a suggestion, but actually prefer
writing it out as `createMockKafkaAvroJobStatusMonitor`, for clarity's sake
Issue Time Tracking
-------------------
Worklog Id: (was: 763369)
Time Spent: 1.5h (was: 1h 20m)
> GaaS Flow SLA Kills should be retryable if configured
> -----------------------------------------------------
>
> Key: GOBBLIN-1634
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1634
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: William Lo
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> On Gobblin as a Service flows can fail SLAs if they do not receive a Kafka
> event in some designated amount of time.
> Since GaaS supports retrys on failures, these failures due to SLAs should
> also be retryable.
> However, if the flow is cancelled from a user specified event through the API
> we do not want to retry.
> Additionally, we also do not want to retry if a flow is skipped due to
> concurrent jobs running at the same time, as it is unlikely without a more
> sophisticated waiting algorithm that the job will be finished by the time the
> job is retried again, wasting resources.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
