hanghangliu commented on code in PR #3504:
URL: https://github.com/apache/gobblin/pull/3504#discussion_r868590988
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnService.java:
##########
@@ -462,7 +448,7 @@ public synchronized void
requestTargetNumberOfContainers(YarnContainerRequestBun
for(; requestedContainerCount < desiredContainerCount;
requestedContainerCount++) {
requestContainer(Optional.absent(),
yarnContainerRequestBundle.getHelixTagResourceMap().get(currentHelixTag));
}
- requestedContainerCountMap.put(currentHelixTag, requestedContainerCount);
+ requestedContainerCountMap.put(currentHelixTag, desiredContainerCount);
Review Comment:
I didn't put this case into consideration: if the desiredContainerCount is
smaller than requestedContainerCount, the for-loop wouldn't update the
requestedContainerCount. So need to use desiredContainerCount instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
