[
https://issues.apache.org/jira/browse/GOBBLIN-1647?focusedWorklogId=771564&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-771564
]
ASF GitHub Bot logged work on GOBBLIN-1647:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/22 20:27
Start Date: 17/May/22 20:27
Worklog Time Spent: 10m
Work Description: jack-moseley commented on code in PR #3508:
URL: https://github.com/apache/gobblin/pull/3508#discussion_r875234262
##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/writer/MetadataWriterKeys.java:
##########
@@ -15,33 +15,37 @@
* limitations under the License.
*/
-package org.apache.gobblin.iceberg.writer;
+package org.apache.gobblin.hive.writer;
-public class IcebergMCEMetadataKeys {
+public class MetadataWriterKeys {
public static final String METRICS_NAMESPACE_ICEBERG_WRITER =
"IcebergWriter";
public static final String ICEBERG_COMMIT_EVENT_NAME =
"IcebergMetadataCommitEvent";
+ public static final String HIVE_COMMIT_EVENT_NAME =
"HiveMetadataCommitEvent";
public static final String METADATA_WRITER_FAILURE_EVENT =
"MetadataWriterFailureEvent";
public static final String LAG_KEY_NAME = "endToEndLag";
public static final String SNAPSHOT_KEY_NAME = "currentSnapshotId";
public static final String MANIFEST_LOCATION = "currentManifestLocation";
public static final String SNAPSHOT_INFORMATION_KEY_NAME =
"currentSnapshotDetailedInformation";
- public static final String TABLE_KEY_NAME = "icebergTableName";
- public static final String DATABASE_KEY_NAME = "icebergDatabaseName";
+ public static final String ICEBERG_TABLE_KEY_NAME = "icebergTableName";
+ public static final String ICEBERG_DATABASE_KEY_NAME = "icebergDatabaseName";
public static final String GMCE_TOPIC_NAME = "gmceTopicName";
public static final String GMCE_TOPIC_PARTITION = "gmceTopicPartition";
public static final String GMCE_HIGH_WATERMARK = "gmceHighWatermark";
public static final String GMCE_LOW_WATERMARK = "gmceLowWatermark";
public static final String DATASET_HDFS_PATH = "datasetHdfsPath";
- public static final String FAILURE_EVENT_DB_NAME = "databaseName";
- public static final String FAILURE_EVENT_TABLE_NAME = "tableName";
+ public static final String PARTITION_HDFS_PATH = "partitionHdfsPath";
+ public static final String DATABASE_NAME_KEY = "databaseName";
Review Comment:
I added hive database name as a new key since that key is also used in
sending failure events which is not specific to hive or iceberg, and I don't
think I want to migrate the iceberg key names for backwards compatibility.,
Issue Time Tracking
-------------------
Worklog Id: (was: 771564)
Time Spent: 40m (was: 0.5h)
> Add hive commit GTE to HiveMetadataWriter
> -----------------------------------------
>
> Key: GOBBLIN-1647
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1647
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
