[
https://issues.apache.org/jira/browse/GOBBLIN-1651?focusedWorklogId=772631&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772631
]
ASF GitHub Bot logged work on GOBBLIN-1651:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/22 23:50
Start Date: 19/May/22 23:50
Worklog Time Spent: 10m
Work Description: jack-moseley opened a new pull request, #3512:
URL: https://github.com/apache/gobblin/pull/3512
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1651
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Currently hiveRegister.close() waits for futures with no timeout, which
could cause long delays in GMIP failing/restarting if there is hive slowness.
Adding an option to configure this timeout, and by default in GMIP setting it
to the same timeout as hive calls during normal operation.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 772631)
Remaining Estimate: 0h
Time Spent: 10m
> Add config to set close timeout in HiveRegister
> -----------------------------------------------
>
> Key: GOBBLIN-1651
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1651
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
